Skip to content

GT-451 | Proper leader election and upgrade without using observe and TTL features #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 4, 2023
Merged

GT-451 | Proper leader election and upgrade without using observe and TTL features #367

merged 8 commits into from
Jul 4, 2023

Conversation

nikita-vanyasin
Copy link
Contributor

Based on arangodb/go-driver#518
Generics added to simplify code for master URL.

@nikita-vanyasin nikita-vanyasin marked this pull request as draft June 22, 2023 12:02
@nikita-vanyasin nikita-vanyasin force-pushed the improvement/no-agency-observe-ttl branch 3 times, most recently from d169881 to a009ea2 Compare June 23, 2023 20:14
@nikita-vanyasin nikita-vanyasin changed the title GT-451 | Proper leader election without using observe and TTL features GT-451 | Proper leader election and upgrade without using observe and TTL features Jun 24, 2023
@nikita-vanyasin nikita-vanyasin force-pushed the improvement/no-agency-observe-ttl branch from b7f8247 to 9cb07b4 Compare June 26, 2023 09:14
@nikita-vanyasin nikita-vanyasin marked this pull request as ready for review June 26, 2023 09:57
informalict
informalict approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@informalict informalict left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will have the same code in go-agency-helper

@nikita-vanyasin
Copy link
Contributor Author

I will have the same code in go-agency-helper

@informalict Not sure why it's need there, but feel free to copy the package.
Also note that initial implementation proposed by Lars contains one small issue, it was fixed in this PR.

@informalict
Copy link
Contributor

I will have the same code in go-agency-helper

@informalict Not sure why it's need there, but feel free to copy the package. Also note that initial implementation proposed by Lars contains one small issue, it was fixed in this PR.

because it must be used by ArangoSync, so there are 3 options:

  • copy this logic into ArangoSync
  • copy this logic to go-agency-helper and use it in ArangoSync. the go-agency-helper will be used by ArangoSync anyway because it will use poll functionality.
  • create some public go-arangodb-helper where we can have public useful functions

@nikita-vanyasin nikita-vanyasin marked this pull request as draft June 28, 2023 06:54
@nikita-vanyasin nikita-vanyasin marked this pull request as ready for review June 28, 2023 07:38
@nikita-vanyasin nikita-vanyasin mentioned this pull request Jul 3, 2023
Merged
@nikita-vanyasin nikita-vanyasin force-pushed the improvement/no-agency-observe-ttl branch from 442ef0e to 6c14366 Compare July 4, 2023 08:05
@nikita-vanyasin nikita-vanyasin force-pushed the improvement/no-agency-observe-ttl branch from 6c14366 to ac22bec Compare July 4, 2023 15:07
@nikita-vanyasin nikita-vanyasin merged commit 4fad31d into master Jul 4, 2023
@nikita-vanyasin nikita-vanyasin deleted the improvement/no-agency-observe-ttl branch July 4, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajanikow ajanikow Awaiting requested review from ajanikow ajanikow is a code owner

@informalict informalict Awaiting requested review from informalict

@jwierzbo jwierzbo Awaiting requested review from jwierzbo jwierzbo is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nikita-vanyasin @informalict @jwierzbo