do not disable server statistics for agent instances #300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The arangodb starter seems to set the `--server.statistics false` parameter for agents, which disables all statistics. The original motivation for this was to turn off a background thread in the instance that periodically writes statistics into RocksDB. This background writing of the statistics history causes load and more disk space usage, which we want to avoid on agent instances. However, setting `--server.statistics false` not only disables the background writing of statistics into RocksDB, but also the statistics API and metrics for process statistics. As it was not ideal to have a single startup option to control two different things, since 3.4.9 arangod provides a separate option `--server.statistics-history`. This option controls whether the statistics are written to RocksDB. This is what we want to turn off. The good thing is that when this option is not set, it automatically turns itself off on agents and DB servers. The defaults in arangod are: * `--server.statistics`: always `true`, for all instance types * `--server.statistics-history`: `true` for coordinators, single servers and active failover instances, `false` for agents and DB servers. These are already the optimal settings, so that the arangodb starter does not need to set any statistics-related startup options for arangod. This PR modifies the starter to not set any of the above arangod startup options, as the arangod defaults seem good enough since at least 3.4.9.
jsteemann
changed the title
jsteemann
requested review from
ajanikow,
nikita-vanyasin and
jwierzbo
as code owners
nikita-vanyasin
approved these changes
Jan 26, 2024
jwierzbo
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The arangodb starter seems to set the
--server.statistics falseparameter for agents, which disables all statistics.
The original motivation for this was to turn off a background thread
in the instance that periodically writes statistics into RocksDB.
This background writing of the statistics history causes load and
more disk space usage, which we want to avoid on agent instances.
However, setting
--server.statistics falsenot only disables thebackground writing of statistics into RocksDB, but also the statistics
API and metrics for process statistics.
As it was not ideal to have a single startup option to control two
different things, since 3.4.9 arangod provides a separate option
--server.statistics-history. This option controls whether thestatistics are written to RocksDB. This is what we want to turn off.
The good thing is that when this option is not set, it automatically
turns itself off on agents and DB servers.
The defaults in arangod are:
--server.statistics: alwaystrue, for all instance types--server.statistics-history:truefor coordinators, single serversand active failover instances,
falsefor agents and DB servers.These are already the optimal settings, so that the arangodb starter
does not need to set any statistics-related startup options for arangod.
This PR modifies the starter to not set any of the above arangod startup
options, as the arangod defaults seem good enough since at least 3.4.9.