Add integration test CI check #17
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to make sure that we don't unknowingly introduce changes in the runtime
that break the generator, which relies on its SPI.
We have an package in a subdirectory in the generator repo that we can be used
as an integration test to gate changes to the various repos in Swift OpenAPI
project, including the runtime package.
The generator repo also contains a script that can be used to clone the
integration test package and use
swift package edit
to override a dependencyto check it still functions with the proposed changes.
Modifications
run-integraton-test.sh
script from the generator repo.Result
On each pull request, the integration test package will be built with the
changes proposed in the pull request.
Test Plan
The CI pipeline for this PR will run the integration test because it's been
added to the soundness script, which is run as part of an existing CI pipeline.
I have also validated this locally:
Notes
This PR adds the integration test to the soundness script, but we probably want
to split this out into its own pipeline in the future.