Skip to content

Rename _StringParameterConvertible to _StringConvertible #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

czechboy0
Copy link
Contributor

Motivation

As part of reworking #12, we'll be using the protocol _StringParameterConvertible not just for parameters, but also for bodies, so renaming it accordingly to reflect that.

Modifications

Renamed _StringParameterConvertible to _StringConvertible.

Result

The naming is more accurate now.

Compatibility-wise, this isn't affecting the generator, as this protocol is not used directly by generated code, only indirectly through _AutoLosslessStringConvertible, so we don't even need to stage this change.

Test Plan

All tests pass.

@czechboy0 czechboy0 requested a review from simonjbeaumont June 6, 2023 12:11
@simonjbeaumont simonjbeaumont added the 🔨 semver/patch No public API change. label Jun 6, 2023
Copy link
Collaborator

@simonjbeaumont simonjbeaumont left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Marking as implementation-only, assuming that's correct?

@czechboy0
Copy link
Contributor Author

Yup, while this is a public symbol, it's an underscored marker protocol that nothing external should be using, so the same guarantees as SPI.

@czechboy0 czechboy0 merged commit 6d7f2e9 into apple:main Jun 6, 2023
@czechboy0 czechboy0 deleted the hd-rename-string-parameter-convertible branch June 6, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants