Rename _StringParameterConvertible to _StringConvertible #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonjbeaumont
approved these changes
Jun 6, 2023
|
Yup, while this is a public symbol, it's an underscored marker protocol that nothing external should be using, so the same guarantees as SPI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As part of reworking #12, we'll be using the protocol
_StringParameterConvertiblenot just for parameters, but also for bodies, so renaming it accordingly to reflect that.Modifications
Renamed
_StringParameterConvertibleto_StringConvertible.Result
The naming is more accurate now.
Compatibility-wise, this isn't affecting the generator, as this protocol is not used directly by generated code, only indirectly through
_AutoLosslessStringConvertible, so we don't even need to stage this change.Test Plan
All tests pass.