Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

fix: Allow # and @ in api param names #102

Merged
merged 1 commit into from
Aug 13, 2020
Merged

fix: Allow # and @ in api param names #102

merged 1 commit into from
Aug 13, 2020

Conversation

GentileFulvio
Copy link
Contributor

I'll be honest not sure if you want this to be fixes but I had this issue mentioned here apidoc/apidoc#899 that I can't use #'s in my param names. So I guess this fixes that.

There is still a failing test also mentioned in the issue linked. Didn't want to touch it though because it's not really part of this commit/issue as this commit fixes a specific issue (The test was already broken before I added any changes). I added a new test files that explicitly tests the api_param parser instead which seemed easier than the other tests you already have in the project. Let me know what you think.

Perhaps I should include other characters as well as mentioned in the following issues. #3 #64 #66

@NicolasCARPi
Copy link
Collaborator

Hello,

Thanks!

I think it would be nice to include other characters too.

@GentileFulvio
Copy link
Contributor Author

Could you provide a list of characters that should be accepted ?

['#','@', ...] ?

@NicolasCARPi
Copy link
Collaborator

The . too I believe.

@GentileFulvio
Copy link
Contributor Author

Added the @ added a test for the . as well apparently that should already work.

@GentileFulvio GentileFulvio changed the title fix: Allow # in api param names fix: Allow # and . in api param names Aug 8, 2020
@GentileFulvio GentileFulvio changed the title fix: Allow # and . in api param names fix: Allow # and @ in api param names Aug 8, 2020
@NicolasCARPi
Copy link
Collaborator

Yes in fact the . is already used for array-like params.

@NicolasCARPi NicolasCARPi merged commit 393b16f into apidoc:dev Aug 13, 2020
@NicolasCARPi
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants