-
Notifications
You must be signed in to change notification settings - Fork 28.6k
[SPARK-35599][PYTHON] Adjust check_exact
parameter for older pd.testing
#32772
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test build #139298 has finished for PR 32772 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status success |
check_exact
parameter for older pd.testingcheck_exact
parameter for older pd.testing
Test build #139358 has finished for PR 32772 at commit
|
Kubernetes integration test starting |
Kubernetes integration test status success |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Doc builds failed. I will rebase and retest. |
Test build #139362 has finished for PR 32772 at commit
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
Merged to master. |
What changes were proposed in this pull request?
Adjust the
check_exact
parameter for non-numeric columns to ensure pandas-on-Spark tests passed with all pandas versions.Why are the changes needed?
pd.testing
utils are utilized in pandas-on-Spark tests.Due to pandas-dev/pandas#35446,
check_exact=True
for non-numeric columns doesn't work for older pd.testing utils, e.g.assert_series_equal
. We wanted to adjust that to ensure pandas-on-Spark tests pass for all pandas versions.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Existing unit tests.
Keyword: SPARK-35337