Simplify dependency upgrade process and upgrade Pulsar C++ client to 3.1.0 #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
force-pushed
the
bewaremypower/update-pulsar-cpp-version
branch
3 times, most recently
from
6d7e00e to
3a6b263
Compare
BewareMyPower
changed the title
BewareMyPower
force-pushed
the
bewaremypower/update-pulsar-cpp-version
branch
from
3a6b263 to
3d45687
Compare
…3.1.0 ### Motivation Currently there are many files that require the download URLs of dependencies to download them. It's hard to maintain if some download URL changed. For example, apache#17 updates the ZLib download URL under https://zlib.net/fossils/ for macOS build. However, the ZLib download URL for Linux is under https://github.com/madler/zlib/archive/. The same goes for the Pulsar C++ client, it's hard to test another URL because the candidates and the official releases are stored in different paths. ### Modifications Add a `dep-url.sh` to provide two shell functions: - `pulsar_cpp_base_url`: Print the base URL of the Pulsar C++ client release, there are the source code or binaries in the subpath. - `download_dependency`: Download the source code according to the dependency file and the dependency name. Then apply the `dep-url.sh` in all files that need to download the source or binary of the dependencies. In addition, this PR upgrades the `pulsar-cpp` dependency to 3.1.0 so that the Windows build can depend on an official release.
BewareMyPower
force-pushed
the
bewaremypower/update-pulsar-cpp-version
branch
from
3d45687 to
3c84c9e
Compare
|
Now, all tests passed. Wait for the official C++ client 3.1.0 release. |
BewareMyPower
changed the title
merlimat
approved these changes
Dec 7, 2022
|
Let's merge it first. After the official 3.1.0 release is done, we only need to update the URL in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Currently there are many files that require the download URLs of dependencies to download them. It's hard to maintain if some download URL changed. For example, #17 updates the ZLib download URL under https://zlib.net/fossils/ for macOS build. However, the ZLib download URL for Linux is under https://github.com/madler/zlib/archive/. The same goes for the Pulsar C++ client, it's hard to test another URL because the candidates and the official releases are stored in different paths.
Modifications
Add a
dep-url.shto provide two shell functions:pulsar_cpp_base_url: Print the base URL of the Pulsar C++ client release, there are the source code or binaries in the subpath.download_dependency: Download the source code according to the dependency file and the dependency name.Then apply the
dep-url.shin all files that need to download the source or binary of the dependencies.In addition, this PR upgrades the
pulsar-cppdependency to 3.1.0 so that the Windows build can depend on an official release.