Skip to content

Support TableView #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 7, 2025
Merged

Conversation

BewareMyPower
Copy link
Contributor

@BewareMyPower BewareMyPower commented May 2, 2025

Fixes #217

Upgrade the C++ client to 3.7.1 to include this fix: apache/pulsar-client-cpp#487

Compared to the Java TableView API, only a few methods are added.

keySet(), values() and entrySet() can be implemented by for_each. Take entrySet() for example:

        entries = dict()
        table_view.for_each(lambda key, value: entries.__setitem__(key, value))

isEmpty() can be implemented by __len__() and containsKey() can be implemented by get().

listen() and refresh() are not added because it's also missed in the C++ client.

@BewareMyPower BewareMyPower added this to the 3.7.0 milestone May 2, 2025
@BewareMyPower BewareMyPower self-assigned this May 2, 2025
@BewareMyPower BewareMyPower marked this pull request as draft May 2, 2025 09:40
@BewareMyPower BewareMyPower changed the title (WIP) Support TableView Support TableView May 6, 2025
@BewareMyPower
Copy link
Contributor Author

BewareMyPower commented May 7, 2025

We need to wait https://dist.apache.org/repos/dist/release/pulsar/pulsar-client-cpp-3.7.1/ to be synchronized to https://archive.apache.org/dist/pulsar/. For now, I used the previous URL. I will revert ba3684b after it's synchronized.

@BewareMyPower BewareMyPower marked this pull request as ready for review May 7, 2025 03:24
This reverts commit ba3684b.
@BewareMyPower BewareMyPower merged commit 53852ff into apache:main May 7, 2025
11 checks passed
@BewareMyPower BewareMyPower deleted the bewaremypower/tableview branch May 7, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for tableview in python client.
2 participants