Skip to content

Update to bookkeeper client 4.16.1 #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Update to bookkeeper client 4.16.1 #111

merged 1 commit into from
Apr 20, 2023

Conversation

merlimat
Copy link
Contributor

The new BK client is now working with newer version of Grpc, so we can upgrade and use Grpc >1.37 which comes with pre-packaged binaries.

The new BK client is now working with newer version of Grpc, so we can upgrade and use Grpc >1.37 which comes with pre-packaged binaries.
@merlimat merlimat added the build label Apr 19, 2023
@merlimat merlimat added this to the 3.2.0 milestone Apr 19, 2023
@merlimat merlimat requested review from BewareMyPower and shibd April 19, 2023 17:24
Copy link
Contributor

@BewareMyPower BewareMyPower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to drop the "functions" dependency. Currently, this repo does not maintain any code related to the functions, except the basic interface here, which does not has any external dependency.

These dependencies should be maintained in the main repo. Once the implementation of the Python Functions changed, these dependencies would be outdated.

I have sent an email to discuss: https://lists.apache.org/thread/5s2l9vgt5f973psb6xlttpmy4rpym7zh. WDYT?

@merlimat
Copy link
Contributor Author

These dependencies should be maintained in the main repo. Once the implementation of the Python Functions changed, these dependencies would be outdated.

I'd leave that as a separate PR. Before we can drop it from here, we need to have an alternative package in PyPI and documentation updates in Pulsar repo.

This change for now will simplify installing the wheel package by accepting a newer grpc client.

@merlimat merlimat merged commit cf2c7c4 into main Apr 20, 2023
@BewareMyPower BewareMyPower deleted the merlimat-patch-1 branch April 21, 2023 02:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants