Skip to content

[chore] Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull #2290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 27, 2025

Conversation

Pankraz76
Copy link
Contributor

@Pankraz76 Pankraz76 commented May 2, 2025

@Pankraz76 Pankraz76 marked this pull request as ready for review May 2, 2025 18:42
@Pankraz76 Pankraz76 changed the title Pull #2287: Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull May 2, 2025
Pankraz76 pushed a commit to Pankraz76/maven that referenced this pull request May 2, 2025
… custom null checks with Objects.requireNonNull
@mthmulders mthmulders changed the title Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull May 6, 2025
Pankraz76 pushed a commit to Pankraz76/maven that referenced this pull request May 6, 2025
… custom null checks with Objects.requireNonNull
@Pankraz76 Pankraz76 requested a review from olamy May 6, 2025 14:42
… custom null checks with Objects.requireNonNull
@Pankraz76 Pankraz76 changed the title Pull #2290: Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull May 13, 2025
@Pankraz76 Pankraz76 changed the title Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull [chore] Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull May 13, 2025
@Pankraz76 Pankraz76 closed this May 20, 2025
@Pankraz76 Pankraz76 reopened this May 23, 2025
@Pankraz76 Pankraz76 requested a review from elharo May 23, 2025 20:42
Copy link
Contributor

@elharo elharo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we already did this, but I guess not

@Pankraz76
Copy link
Contributor Author

but I guess not

merge not. It seems that its convention here to to merge immediately so others can review too. Might enable an auto merge after 10 days non rejected.

@Bukama
Copy link

Bukama commented May 24, 2025

Might enable an auto merge after 10 days non rejected.

Not rejected does not mean approved (at least for me) and taken into account how large Maven is, that the Maven team is not a company and the current situation about cyber attacks (including AI generated ones) I don't think auto merges are a good idea.

@michael-o
Copy link
Member

Might enable an auto merge after 10 days non rejected.

Not rejected does not mean approved (at least for me) and taken into account how large Maven is, that the Maven team is not a company and the current situation about cyber attacks (including AI generated ones) I don't think auto merges are a good idea.

I am totally against any automerges.

@Pankraz76
Copy link
Contributor Author

yes, its a security risk not haven taken into account. Thanks for hint.
If its only possible then with min. approval count increased to 2, better 3, this is altho not pleasant.

@Pankraz76
Copy link
Contributor Author

@olamy any feedback from your side?

If not might consider merge.

Its just renaming of old method to new one, therefore no delta possible, and removal. No risky s&r brute force.

@elharo elharo merged commit e80c9f5 into apache:master May 27, 2025
36 checks passed
@github-actions github-actions bot added this to the 4.0.0-rc-4 milestone May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants