-
Notifications
You must be signed in to change notification settings - Fork 2.7k
[chore] Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
#2290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelXmlFactoryTest.java
Show resolved
Hide resolved
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
… custom null checks with Objects.requireNonNull
Modernize codebase with Java improvements - Replace custom null checks with Objects.requireNonNull
Objects.requireNonNull
impl/maven-impl/src/main/java/org/apache/maven/impl/ImplUtils.java
Outdated
Show resolved
Hide resolved
… custom null checks with Objects.requireNonNull
… custom null checks with Objects.requireNonNull
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultArtifactCoordinatesFactory.java
Show resolved
Hide resolved
impl/maven-impl/src/main/java/org/apache/maven/impl/AbstractSession.java
Show resolved
Hide resolved
Objects.requireNonNull
Objects.requireNonNull
Objects.requireNonNull
Objects.requireNonNull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we already did this, but I guess not
merge not. It seems that its convention here to to merge immediately so others can review too. Might enable an auto merge after 10 days non rejected. |
Not rejected does not mean approved (at least for me) and taken into account how large Maven is, that the Maven team is not a company and the current situation about cyber attacks (including AI generated ones) I don't think auto merges are a good idea. |
I am totally against any automerges. |
yes, its a security risk not haven taken into account. Thanks for hint. |
@olamy any feedback from your side? If not might consider merge. Its just renaming of old method to new one, therefore no delta possible, and removal. No risky s&r brute force. |
Modernize codebase with Java improvements - Replace custom null checks with
Objects.requireNonNull
toList()
instead ofCollectors.toList()
) #2287