Subscription: fully managed tsfile parsing process for tsfile format topic #15524
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveYurongSu
approved these changes
May 19, 2025
VGalaxies
added a commit
to VGalaxies/iotdb
that referenced
this pull request
May 19, 2025
SteveYurongSu
pushed a commit
that referenced
this pull request
May 20, 2025
This was referenced May 21, 2025
SteveYurongSu
pushed a commit
that referenced
this pull request
May 29, 2025
… commit (#15598) Consider the historical data export snapshot scenario: 1. The events delivered upstream are, in order, the tsfile event and the termination event. 2. The tsfile event is parsed into multiple tablet events, and then the reference count of the tsfile event is set to 0 (should report as false). 3. Assuming that for some reason the tablet events were not sent to the peer in time, the reference count of the transfer termination event is set to 0 (should report as true). 4. At this point, because the tablet events were not enriched with a commit id (see Subscription: fully managed tsfile parsing process for tsfile format topic #15524), the termination event successfully marks the corresponding DR complete, which in turn leads to data loss.
VGalaxies
added a commit
to VGalaxies/iotdb
that referenced
this pull request
May 29, 2025
… commit (apache#15598) Consider the historical data export snapshot scenario: 1. The events delivered upstream are, in order, the tsfile event and the termination event. 2. The tsfile event is parsed into multiple tablet events, and then the reference count of the tsfile event is set to 0 (should report as false). 3. Assuming that for some reason the tablet events were not sent to the peer in time, the reference count of the transfer termination event is set to 0 (should report as true). 4. At this point, because the tablet events were not enriched with a commit id (see Subscription: fully managed tsfile parsing process for tsfile format topic apache#15524), the termination event successfully marks the corresponding DR complete, which in turn leads to data loss.
SteveYurongSu
pushed a commit
that referenced
this pull request
May 29, 2025
… commit (#15598) (#15601) Consider the historical data export snapshot scenario: 1. The events delivered upstream are, in order, the tsfile event and the termination event. 2. The tsfile event is parsed into multiple tablet events, and then the reference count of the tsfile event is set to 0 (should report as false). 3. Assuming that for some reason the tablet events were not sent to the peer in time, the reference count of the transfer termination event is set to 0 (should report as true). 4. At this point, because the tablet events were not enriched with a commit id (see Subscription: fully managed tsfile parsing process for tsfile format topic #15524), the termination event successfully marks the corresponding DR complete, which in turn leads to data loss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow up #14856