Skip to content

Load: fix memory leak when failed to send chunk data in first phase #15518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 19, 2025
Merged

Load: fix memory leak when failed to send chunk data in first phase #15518

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions ...rc/main/java/org/apache/iotdb/db/queryengine/plan/scheduler/load/LoadTsFileScheduler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -707,12 +707,8 @@ private boolean addOrSendChunkData(ChunkData chunkData) throws LoadFileException
if (pieceNode.getDataSize() == 0) { // total data size has been reduced to 0
break;
}
if (!scheduler.dispatchOnePieceNode(pieceNode, replicaSet)) {
return false;
}
final boolean isDispatchSuccess = scheduler.dispatchOnePieceNode(pieceNode, replicaSet);

dataSize -= pieceNode.getDataSize();
block.reduceMemoryUsage(pieceNode.getDataSize());
regionId2ReplicaSetAndNode.replace(
sortedRegionId,
new Pair<>(
Expand All @@ -722,6 +718,14 @@ private boolean addOrSendChunkData(ChunkData chunkData) throws LoadFileException
singleTsFileNode
.getTsFileResource()
.getTsFile()))); // can not just remove, because of deletion
dataSize -= pieceNode.getDataSize();
block.reduceMemoryUsage(pieceNode.getDataSize());

if (!isDispatchSuccess) {
// Currently there is no retry, so return directly
return false;
}

if (isMemoryEnough()) {
break;
}
Expand Down