Skip to content

GH-46599: [C++][Doc][Parquet] Update supported types documentation #46620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 2, 2025

Conversation

paleolimbot
Copy link
Member

@paleolimbot paleolimbot commented May 27, 2025

Rationale for this change

We now support more types but the documentation suggested that some weren't supported.

What changes are included in this PR?

Documentation was updated to reflect the status of supported types.

Are these changes tested?

No code changes!

Are there any user-facing changes?

No

Copy link

⚠️ GitHub issue #46599 has been automatically assigned in GitHub to PR creator.

@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels May 27, 2025
@paleolimbot paleolimbot marked this pull request as ready for review May 27, 2025 19:31
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels May 30, 2025
@paleolimbot paleolimbot requested a review from pitrou May 30, 2025 15:06
@github-actions github-actions bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels May 30, 2025
Copy link
Member

@pitrou pitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paleolimbot . Just some formatting suggestions.

paleolimbot and others added 2 commits June 2, 2025 09:40
@github-actions github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 2, 2025
@paleolimbot paleolimbot merged commit 1ffc766 into apache:main Jun 2, 2025
5 of 6 checks passed
@paleolimbot paleolimbot removed the awaiting change review Awaiting change review label Jun 2, 2025
Copy link

After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 1ffc766.

There were 68 benchmark results with an error:

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about 1 possible false positive for unstable benchmarks that are known to sometimes produce them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants