GH-46613: [GLib] Add GArrowBaseListDataType #46615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Could you use this as the parent class of |
|
@kou Thank you for your review you meant the following. correct? If so, fixed -G_DECLARE_DERIVABLE_TYPE(
- GArrowListDataType, garrow_list_data_type, GARROW, LIST_DATA_TYPE, GArrowDataType)
+G_DECLARE_DERIVABLE_TYPE(GArrowListDataType,
+ garrow_list_data_type,
+ GARROW,
+ LIST_DATA_TYPE,
+ GArrowBaseListDataType) |
kou
reviewed
May 28, 2025
github-actions
bot
added
awaiting changes
Co-authored-by: Sutou Kouhei <[email protected]>
Co-authored-by: Sutou Kouhei <[email protected]>
github-actions
bot
added
awaiting change review
|
Thanks! All suggested change applied. |
kou
reviewed
May 29, 2025
github-actions
bot
added
awaiting changes
|
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit 5890232. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
GLib should be able to use
arrow::BaseListType.What changes are included in this PR?
Add
GArrowBaseListDataTypeand use it as a base class ofGArrowListDataType.Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.