fix: error reading multiple batches of Dict(_, FixedSizeBinary(_))
#7585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertlockett
force-pushed
the
7545-fix-reading-dict-fsb-all-batches
branch
from
5c504a5 to
ef8e835
Compare
alamb
approved these changes
Jun 2, 2025
There was a problem hiding this comment.
Thank you @albertlockett -- this makes sense to me
cc @etseidl
| @@ -2158,6 +2158,41 @@ mod tests { | |||
| ); | |||
| } | |||
|
|
|||
| #[test] | |||
| fn test_read_dict_fixed_size_binary() { | |||
There was a problem hiding this comment.
I verified this test fails without the code change:
thread 'arrow::arrow_reader::tests::test_read_dict_fixed_size_binary' panicked at parquet/src/arrow/buffer/offset_buffer.rs:133:48:
called `Result::unwrap()` on an `Err` value: InvalidArgumentError("Expected 1 buffers in array of type FixedSizeBinary(8), got 2")
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
etseidl
approved these changes
Jun 2, 2025
Co-authored-by: Ed Seidl <[email protected]>
|
Thanks again @albertlockett and @etseidl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Dictionary(u8, FixedSizeBinary(_))using datafusion. #7545Rationale for this change
See comment here for what I think is the root cause of the issue: #7545 (comment)
What changes are included in this PR?
Are there any user-facing changes?
No breaking changes. Users may notice that if they try to collect batches with arrow type
Dictionary(_, FixedSizeBinary(_))when reading their parquet file, that there will no longer be an error