Fluid simulation results API #402
Conversation
# Conflicts: # src/ansys/dpf/post/dataframe.py # src/ansys/dpf/post/simulation.py
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 83.03% 81.63% -1.41%
==========================================
Files 35 39 +4
Lines 3531 4122 +591
==========================================
+ Hits 2932 3365 +433
- Misses 599 757 +158 |
|
|
||
|
|
||
| class Phase: | ||
| """Physical state of a given species in a fluid simulation.""" |
There was a problem hiding this comment.
Did you take these kind a descriptions from fluent documentation?
There was a problem hiding this comment.
@cbellot000 I do not think so, no
| ] | ||
| return self._model.metadata.result_info.available_results | ||
|
|
||
| @property |
There was a problem hiding this comment.
@PProfizi could you pease point me to the usage of the mesh info ?
There was a problem hiding this comment.
@cbellot000 the MeshInfo is not yet available
| class Zones: | ||
| """List of fluid zones.""" | ||
|
|
||
| def __init__(self): |
There was a problem hiding this comment.
do we have a way to access zones by name?
There was a problem hiding this comment.
@cbellot000 once the MeshInfo is available, sure, but not now
Co-authored-by: Camille Bellot <[email protected]>
| @@ -194,18 +195,22 @@ jobs: | |||
| if: startsWith(github.head_ref, 'master') || github.event.action == 'ready_for_review' || !github.event.pull_request.draft | |||
| uses: ./.github/workflows/examples.yml | |||
| with: | |||
| ANSYS_VERSION: '241' | |||
| ANSYS_VERSION: "241" | |||
There was a problem hiding this comment.
Can you use the environment variable?
| ANSYS_VERSION: "241" | |
| ANSYS_VERSION: ${{env.ANSYS_VERSION}} |
| # # To directly extract the temperature data for only one phase, | ||
| # # pass the 'temperature' method a 'phases' argument. | ||
| # # This argument must be given a list of phase unique identifiers, which appear | ||
| # # in the dataframe in the phase label column between parentheses, | ||
| # # or as listed | ||
| # # under the 'Available qualifier labels' section of the metadata on the result | ||
| # # water_temperature = simulation.temperature(phases=["Copper"]) | ||
| # water_temperature = simulation.enthalpy( | ||
| # phases=[2] | ||
| # ) | ||
| # print(water_temperature) | ||
| # # The dataframe obtained now only stores data for the water phase. |
There was a problem hiding this comment.
Is it expected to have this entire section commented out.
There was a problem hiding this comment.
@MaxJPRey that was to due to a bug server-side which has been resolved in the meantime.
I'll uncomment it.
To do in further PRs:
MeshInfoMeshInfoto completeZonesSimulation.zonesproperty to prevent requests on bothFaceZoneandCellZone, document it