Skip to content

Commit ff58a15

Browse files
committed
drm/vc4: Use correct path to trace include
The header comment in include/trace/define_trace.h specifies that the TRACE_INCLUDE_PATH needs to be relative to the define_trace.h header rather than the trace file including it. Most instances get that wrong and work around it by adding the $(src) directory to the include path. While this works, it is preferable to refer to the correct path to the trace file in the first place and avoid any workaround. Acked-by: Christian König <[email protected]> Acked-by: Daniel Vetter <[email protected]> Signed-off-by: Thierry Reding <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent f23ef8e commit ff58a15

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

drivers/gpu/drm/vc4/Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,5 +24,3 @@ vc4-y := \
2424
vc4-$(CONFIG_DEBUG_FS) += vc4_debugfs.o
2525

2626
obj-$(CONFIG_DRM_VC4) += vc4.o
27-
28-
CFLAGS_vc4_trace_points.o := -I$(src)

drivers/gpu/drm/vc4/vc4_trace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,5 +59,5 @@ TRACE_EVENT(vc4_wait_for_seqno_end,
5959

6060
/* This part must be outside protection */
6161
#undef TRACE_INCLUDE_PATH
62-
#define TRACE_INCLUDE_PATH .
62+
#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/vc4
6363
#include <trace/define_trace.h>

0 commit comments

Comments
 (0)