Skip to content

Commit f23ef8e

Browse files
committed
drm/armada: Use correct path to trace include
The header comment in include/trace/define_trace.h specifies that the TRACE_INCLUDE_PATH needs to be relative to the define_trace.h header rather than the trace file including it. Most instances get that wrong and work around it by adding the $(src) directory to the include path. While this works, it is preferable to refer to the correct path to the trace file in the first place and avoid any workaround. Acked-by: Christian König <[email protected]> Acked-by: Daniel Vetter <[email protected]> Signed-off-by: Thierry Reding <[email protected]> Link: https://patchwork.freedesktop.org/patch/msgid/[email protected]
1 parent d99ce55 commit f23ef8e

File tree

2 files changed

+1
-3
lines changed

2 files changed

+1
-3
lines changed

drivers/gpu/drm/armada/Makefile

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,3 @@ armada-y += armada_510.o
44
armada-$(CONFIG_DEBUG_FS) += armada_debugfs.o
55

66
obj-$(CONFIG_DRM_ARMADA) := armada.o
7-
8-
CFLAGS_armada_trace.o := -I$(src)

drivers/gpu/drm/armada/armada_trace.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,5 +62,5 @@ TRACE_EVENT(armada_ovl_plane_work,
6262

6363
/* This part must be outside protection */
6464
#undef TRACE_INCLUDE_PATH
65-
#define TRACE_INCLUDE_PATH .
65+
#define TRACE_INCLUDE_PATH ../../drivers/gpu/drm/armada
6666
#include <trace/define_trace.h>

0 commit comments

Comments
 (0)