Skip to content

fix(binaries): filter m1 mac chromedriver versions #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2021

Conversation

jimivdw
Copy link
Contributor

@jimivdw jimivdw commented Jan 7, 2021

Fixes #476

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jan 7, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Jan 7, 2021
@jimivdw jimivdw force-pushed the fix-m1-chromedriver branch from 36b52a4 to 70d7a61 Compare January 7, 2021 16:00
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Jan 7, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jan 7, 2021
@jimivdw jimivdw force-pushed the fix-m1-chromedriver branch from 70d7a61 to 20c606f Compare January 7, 2021 16:02
@jimivdw
Copy link
Contributor Author

jimivdw commented Jan 8, 2021

Really hoping someone can take a look at this, since it's pretty annoying that we now basically cannot use webdriver-manager to get the chromedriver on non-m1 macs. @cnishina perhaps?

@cnishina
Copy link
Contributor

cnishina commented Jan 9, 2021

This looks good to me. Thank you for doing this. I'll try to publish something to npm this week for this fix.

@cnishina cnishina merged commit 17db8a2 into angular:legacy Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webdriver-manager downloads mac64_m1 on x86_64 arch
3 participants