feat: Prompt to use the Ivy Language Service if VE is detected #1099
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
force-pushed
the
promptToUseIvyLS
branch
2 times, most recently
from
00d2b75 to
8d74f07
Compare
kyliau
suggested changes
Feb 3, 2021
client/src/client.ts
Outdated
| 'Ignore', | ||
| ); | ||
| if (selection === enableIvy) { | ||
| config.update('angular.experimental-ivy', true); |
There was a problem hiding this comment.
Is this per-workspace or global?
There was a problem hiding this comment.
The default is WorkspaceFolder - I've updated this to be global. We might want to discuss how we want to approach it. Maybe the ignore selection is global and the enable option is per workspace? WDYT?
atscott
force-pushed
the
promptToUseIvyLS
branch
2 times, most recently
from
2701ea7 to
2339d96
Compare
kyliau
reviewed
Feb 5, 2021
In order to drive adoption of the new Ivy Language Service before it becomes the default in v12, this commit adds a prompt for users to enable it if they are using `@angular/core` v9+. Fixes angular#1095
atscott
force-pushed
the
promptToUseIvyLS
branch
from
2339d96 to
0b125c4
Compare
kyliau
approved these changes
Feb 6, 2021
Closed
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to drive adoption of the new Ivy Language Service before it
becomes the default in v12, this commit adds a prompt for users to
enable it if they are using
@angular/corev9+.Fixes #1095