Skip to content
This repository was archived by the owner on Sep 5, 2024. It is now read-only.

fix(calendar): allow tabbing out when in standalone mode #12023

Merged
merged 1 commit into from
Sep 23, 2020

Conversation

Splaktar
Copy link
Contributor

PR Checklist

Please check that your PR fulfills the following requirements:

  • The commit message follows our guidelines
  • Tests for the changes have been added or this is not a bug fix / enhancement
  • Docs have been added, updated, or were not required

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Enhancement
[ ] Documentation content changes
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

  • Using the md-calendar outside of the md-datepicker breaks the page's tab order.

Issue Number:
Fixes #9794

What is the new behavior?

  • using the md-calendar outside of the md-datepicker no longer breaks the page's tab order
  • change one access of the global document to use $document
  • improve Closure types
  • update JSDoc for CalendarCtrl.handleKeyEvent()

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

- using the `md-calendar` outside of the `md-datepicker` no longer
  breaks the page's tab order
- change one access of the global `document` to use `$document`
- improve Closure types
- update JSDoc for `CalendarCtrl.handleKeyEvent()`

Fixes #9794
@googlebot googlebot added the cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ label Sep 23, 2020
@Splaktar Splaktar self-assigned this Sep 23, 2020
@Splaktar Splaktar added this to the 1.2.1 milestone Sep 23, 2020
@Splaktar Splaktar requested a review from annieyw September 23, 2020 01:55
@Splaktar Splaktar added a11y This issue is related to accessibility P2: required Issues that must be fixed. pr: merge ready This PR is ready for a caretaker to review type: bug labels Sep 23, 2020
@Splaktar Splaktar added the pr: lgtm This PR has been approved by the reviewer label Sep 23, 2020
@Splaktar Splaktar merged commit 93518bb into master Sep 23, 2020
@Splaktar Splaktar deleted the calendar-cant-tab-out branch September 23, 2020 21:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
a11y This issue is related to accessibility cla: yes PR author has signed Google's CLA: https://opensource.google.com/docs/cla/ P2: required Issues that must be fixed. pr: lgtm This PR has been approved by the reviewer pr: merge ready This PR is ready for a caretaker to review type: bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

calendar: doesn't support tabbing out of it when used standalone
3 participants