$mdToast increases watchers but does not remove them if multiple toasts are displayed within a digest.

This is kind of hard to explain, bare with me.

Using $mdToast, if you click one of the buttons to display a toast, rapidly enough so the toast does not disappear between clicks (and multiple toasts are created within 1 digest cycle), it will increase the watcher count considerably but will not remove all of the watchers for all of the toasts.

$mdToast only decreases the watchers for the last toast created within a digest cycle.

Demo: http://codepen.io/anon/pen/avLPqP

@ThomasBurleson please review and Triage.

[thesamchris]

Hello @robertbaker. If your problem is that the toasts are not leaving then this should solve your problem.

 var toast = $mdToast.simple()
            .content(message)
            .action(action)
            .highlightAction(false)
            .position('bottom left');
   setTimeout(function() {
      $mdToast.show(toast);
   }, 99); 

`

I encountered this problem before, where two events would trigger a toast and the second one would be left.

@samuelchristopher No that's not the issue, there is a watcher leak, nothing to do with the UI.

[nicky-lenaers]

I encountered this issue when calling this event two times as it gets triggered twice sometimes:
$rootScope.$broadcast('http-error', res.data.message)

and listening on it:
$rootScope.$on('http-error', (event, message) => ToastService.simple(message));

For reference, the service function simple looks like:

public simple = (message) => {
    this.$mdToast.show(
        this.$mdToast.simple()
        .position('bottom right')          
        .hideDelay(1000)
        .textContent(message)
    );
}

In this case, the toast simply does not go away.

[devversion]

This may be related to #6633, since multiple toasts are shown within the same interim element. When this bug is fixed, then the toasts will probably hide.

This bug is more about unattaching the events, disposing them so the number
of watchers does not increase when you display multiple toasts at the same
time, even if only one is visible.

If you open 5 toasts at the same time, the number of watchers increase but
only the last toast you opened will have the watchers removed once it
dismisses.

On Wed, Mar 23, 2016, 7:25 AM Paul Gschwendtner notifications@github.com
wrote:

This may be related to #6633
#6633, since multiple toasts
are shown within the same interim element. When this bug is fixed, then the
toasts will probably hide.

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#5193 (comment)