This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Ignore private annotation for constructors #300
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up adding an
isConstructor
check in many places where there is anisPrivate
check. I also made it so it doesn't emit the constructor if it is private. It doesn't prevent calling new on a private class but I felt that was the logic thing to do until typescript supports private constructors.