Skip to content
This repository was archived by the owner on Feb 26, 2024. It is now read-only.

Ignore private annotation for constructors #300

Conversation

lambertjamesd
Copy link
Contributor

@lambertjamesd lambertjamesd commented Jun 30, 2016

I ended up adding an isConstructor check in many places where there is an isPrivate check. I also made it so it doesn't emit the constructor if it is private. It doesn't prevent calling new on a private class but I felt that was the logic thing to do until typescript supports private constructors.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@lambertjamesd lambertjamesd force-pushed the ignore-private-annotation-for-constructors branch from f2b42b9 to 79b458f Compare June 30, 2016 17:18
@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@rkirov
Copy link
Contributor

rkirov commented Jul 11, 2016

merged

@rkirov rkirov closed this Jul 11, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants