Skip to content

fix(@ngtools/webpack): fix Angular 5 lazy routes in es2015 #7693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

filipesilva
Copy link
Contributor

Fix #7689

@@ -358,6 +358,14 @@ export class AotPlugin implements Tapable {
// being built.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the changes here? This is only for Angular 5, isn't it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's still possible to turn off the new compiler (--no-experimental-angular-compiler) so this plugin should still work with Angular 5.

@hansl
Copy link
Contributor

hansl commented Sep 14, 2017

The commit is not about fixing the warning, it's about fixing the resolution of lazy routes in Angular 5, isn't it?

@filipesilva filipesilva changed the title fix(@ngtools/webpack): fix linker warning in es2015 fix(@ngtools/webpack): fix Angular 5 lazy routes in es2015 Sep 14, 2017
@filipesilva
Copy link
Contributor Author

Fixed commit message.

@petebacondarwin
Copy link
Contributor

where are the tests? :-P

@hansl
Copy link
Contributor

hansl commented Sep 18, 2017

@petebacondarwin we test against Angular 5.0.0 already, with a lazy route :-)

Actually scratch that. We don't have lazy routes testing in nightly. We should. I'll make a PR for that.

@Brocco Brocco merged commit 90e9c82 into angular:master Sep 19, 2017
@filipesilva filipesilva deleted the linker-es2015 branch September 19, 2017 11:59
@filipesilva
Copy link
Contributor Author

@hansl we run this test in nightly, and it tests lazy routes https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/rebuild.ts.

@petebacondarwin
Copy link
Contributor

@filipesilva - If you already have tests for this then why were they not failing already? Or perhaps they were, which is what led to this PR?

@filipesilva
Copy link
Contributor Author

@petebacondarwin because this only failed when lazy routes were being used with es2015. We test the two but separately.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

warning raised if targeting es2015
5 participants