-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@ngtools/webpack): fix Angular 5 lazy routes in es2015 #7693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
9aa8193
to
3485f01
Compare
@@ -358,6 +358,14 @@ export class AotPlugin implements Tapable { | |||
// being built. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need the changes here? This is only for Angular 5, isn't it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still possible to turn off the new compiler (--no-experimental-angular-compiler
) so this plugin should still work with Angular 5.
The commit is not about fixing the warning, it's about fixing the resolution of lazy routes in Angular 5, isn't it? |
3485f01
to
c521f8c
Compare
Fixed commit message. |
where are the tests? :-P |
@petebacondarwin we test against Angular 5.0.0 already, with a lazy route :-) Actually scratch that. We don't have lazy routes testing in nightly. We should. I'll make a PR for that. |
@hansl we run this test in nightly, and it tests lazy routes https://github.com/angular/angular-cli/blob/master/tests/e2e/tests/build/rebuild.ts. |
@filipesilva - If you already have tests for this then why were they not failing already? Or perhaps they were, which is what led to this PR? |
@petebacondarwin because this only failed when lazy routes were being used with es2015. We test the two but separately. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fix #7689