Skip to content

chore(build): set production environment #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2017

Conversation

deini
Copy link
Collaborator

@deini deini commented Aug 7, 2017

build:min is not setting production environment.

So this causes to log to the console even when building for production plus we are not getting webpack to optimize accordingly for prod.

You are currently using minified code outside of NODE_ENV === 'production'. This means that you are running a slower development build of Redux.
You can use loose-envify (https://github.com/zertosh/loose-envify) for browserify or DefinePlugin for webpack (http://stackoverflow.com/questions/30030031) to ensure you have the correct code for your production build.'

@AntJanus

We probably want to upgrade to a newer version of webpack too.

Should close #126

@AntJanus
Copy link
Collaborator

AntJanus commented Aug 8, 2017

I was gonna be against it but minified usually means production, I'm all for it!

@AntJanus
Copy link
Collaborator

AntJanus commented Aug 8, 2017

Yeah, I really want to get on upgrading some of these modules. It's in the 3.5.0 milestone. I'll add this one to it as well and merge it in as soon as I get a chance to test it.

@AntJanus AntJanus added this to the 3.5.0 milestone Aug 8, 2017
@HunterEl
Copy link
Collaborator

HunterEl commented Aug 9, 2017

Ignoring the conflict, I agree with the nature of the change. Thank you.

@deini deini force-pushed the set-node-env-prod branch from 1f16ec1 to c42c30b Compare August 9, 2017 16:13
build:min is not setting production environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants