Port #60195: Allow reusing type nodes that resolve to error types #13
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ports microsoft/TypeScript#60195 to the Go implementation, fixing an issue where error types in isolated declarations mode would cause cascading errors.
Problem
When using isolated declarations with unresolved imports, the compiler would generate additional confusing errors beyond the initial module resolution error. For example:
Previously, this would not only report the module resolution error but also additional type reuse errors, making the output harder to understand.
Solution
Added error type handling to the
tryReuseExistingNonParameterTypeNode
function ininternal/checker/nodebuilderimpl.go
. When an annotation type resolves to an error type, the function now allows reusing the type node to prevent cascading errors.The change follows the same logic as the TypeScript implementation:
annotationType
is an error type, allow reusing the existing type nodeChanges
tryReuseExistingNonParameterTypeNode
ininternal/checker/nodebuilderimpl.go
Testing
Fixes #7.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.