Skip to content

Solver1d hardening to improve resolution with case driving to NaN values. #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

xaviersolau
Copy link

  • improve method to bracket root function evaluations.
  • Update T_Bonds tests
  • Add tests in T_Solvers

see issue #300

QLNet

Thank you for contributing! Take a moment to review our contributing guidelines
to make the process easy and effective for everyone involved.

You must open an issue before embarking on any significant pull request, especially those that
add a new code or change existing tests, otherwise you risk spending a lot of time working
on something that might not end up being merged into the project.

IMPORTANT: By submitting a patch via a Pull Request, you agree to allow the project
owners to license your work under the terms of the BSD3 License.

PR Type

What kind of change does this PR introduce?

[X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[X] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[X] Tests
[ ] Other

Description

Solver1d trying to bracket root function evaluations:

  • Once the Solver1d reach a NaN value on fxMin_ or fxMax_ try to get back to a real value reducing the growth step on xMin_ or xMax_ and try to find a solution.

…lues.

 - improve method to bracket root function evaluations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant