Enable phpcs for the tests folder #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables phpcs checks on files in the
tests
directory, because we should be enforcing coding standards everywhere, including when writing tests. Some notes on the change:// phpcs:ignore
within the test file.class-*
to make the phpcs tests pass, and updates the phpunit config to look for tests in all PHP files in the tests directory. PHPUnit is pretty smart about how it does this, and this change did not result in any difference in execution time for sample tests in this repo, even by looking at a more permissive set of files. See relevant discussion here on where thetest-
prefix came from and how it isn't an official PHPUnit standard, despite being in wide use in WP projects scaffolded using WP-CLI: WordPress.Files.FileName.InvalidClassFileName for tests/test-sample.php WordPress/WordPress-Coding-Standards#882