Skip to content

Enable SQLite by default #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 31, 2023
Merged

Enable SQLite by default #215

merged 2 commits into from
May 31, 2023

Conversation

srtfisher
Copy link
Member

@srtfisher srtfisher commented May 31, 2023 •
edited
Loading

  • Turns on SQLite testing by default.
  • Adds PHP 8.1 testing to the matrix.

stevenslack
stevenslack approved these changes May 31, 2023
View reviewed changes
Copy link
Contributor

@stevenslack stevenslack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question 🎨

tests/bootstrap.php
@@ -8,6 +8,7 @@
*/
\Mantle\Testing\manager()
->maybe_rsync_plugin()
->with_sqlite()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was having issues with the testing framework on my PR. I had to re-run the suite to get it to pass. Does using SQLite help alleviate this issue?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should help speed up testing but I don't think it'll fix any issues

@srtfisher srtfisher merged commit 92d4c58 into develop May 31, 2023
@srtfisher srtfisher deleted the sqlite branch May 31, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenslack stevenslack stevenslack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@srtfisher @stevenslack