feat: new binding via go:linkname #362
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add [WIP] on your title |
y1yang0
changed the title
y1yang0
force-pushed
the
yyang/poc_linkname
branch
28 times, most recently
from
34e32a5 to
98931fc
Compare
y1yang0
force-pushed
the
yyang/poc_linkname
branch
2 times, most recently
from
4514d3f to
6b22d5e
Compare
Merged
y1yang0
force-pushed
the
yyang/poc_linkname
branch
2 times, most recently
from
fff38f7 to
bea9104
Compare
y1yang0
force-pushed
the
yyang/poc_linkname
branch
from
bea9104 to
da4fbe0
Compare
123liuziming
reviewed
May 9, 2025
123liuziming
reviewed
May 9, 2025
| otel_importer.go | ||
| test/fiberv2/v2.43.0/fiber_http | ||
| test/redis/v9.0.5/test_redis_ring |
There was a problem hiding this comment.
Do we need to add those test binary here?
There was a problem hiding this comment.
It's okay, gitignore is somewhat flexible, any unnecessary files generated during the development can be added to it.
123liuziming
reviewed
May 9, 2025
123liuziming
reviewed
May 9, 2025
123liuziming
reviewed
May 9, 2025
123liuziming
reviewed
May 9, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
==========================================
+ Coverage 83.70% 87.01% +3.31%
==========================================
Files 27 25 -2
Lines 1209 1163 -46
==========================================
Hits 1012 1012
+ Misses 159 113 -46
Partials 38 38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch rewrites the code injection mechanism.
We no longer inject by copying code into the user's project and injecting via variable assignment. In the new approach, we will use
go:linknamefor injection. Since the injection is done by the linker through symbol overriding, the hook code is always fully initialized and ready before the target function is called. Therefore, the new implementation eliminates initialization order issues, which is a long-standing pain in older version #48