[LLM:Bugfix] Fix incorrect kv_seq_len in gen_attention_mask() for autoregressive decoding #3403
+1
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the decoding phase (auto-regressive generation),
Llm::generate()
callsforward(input_ids, is_prefill)
withinput_ids.size() == 1
. The current logic inLlm::gen_attention_mask()
setskv_seq_len = seq_len
(whereseq_len=1
for decoding), which is incorrect. This ignores the accumulated history length(mContext->all_seq_len
), leading to mismatched attention masks and affecting the calculation of attention scores, thereby influencing the model's inference results.