Do TseTse checks with typechecker later

The typechecker is known to be slow to create due to microsoft/TypeScript#27997

By moving the non-typechecker checks earlier in the process, I was able to observe significant savings in the `perfTrace.wrap` total times:
- `CheckReturnValueRule`: 1,036ms, down from 2,102ms
- `MustUsePromisesRule`: 119ms, down from 1,174ms

Closes bazel-contrib#359

PiperOrigin-RevId: 225844645

Author: filipesilva

packages/concatjs/third_party/google3/rules_typescript/internal/tsetse/rules/check_return_value_rule.ts

@@ -55,6 +55,12 @@ export class Rule extends AbstractRule {
 }
 
 function checkCallExpression(checker: Checker, node: ts.CallExpression) {
+  // Short-circuit before using the typechecker if possible, as its expensive.
+  // Workaround for https://github.com/Microsoft/TypeScript/issues/27997
+  if (tsutils.isExpressionValueUsed(node)) {
+    return;
+  }
+
   // Check if this CallExpression is one of the well-known functions and returns
   // a non-void value that is unused.
   const signature = checker.typeChecker.getResolvedSignature(node);
@@ -70,9 +76,6 @@ function checkCallExpression(checker: Checker, node: ts.CallExpression) {
         !hasCheckReturnValueJsDoc(node, checker.typeChecker)) {
       return;
     }
-    if (tsutils.isExpressionValueUsed(node)) {
-      return;
-    }
 
     checker.addFailureAtNode(node, FAILURE_STRING);
   }

packages/concatjs/third_party/google3/rules_typescript/internal/tsetse/rules/must_use_promises_rule.ts

@@ -24,6 +24,12 @@ export class Rule extends AbstractRule {
 }
 
 function checkCallExpression(checker: Checker, node: ts.CallExpression) {
+  // Short-circuit before using the typechecker if possible, as its expensive.
+  // Workaround for https://github.com/Microsoft/TypeScript/issues/27997
+  if (tsutils.isExpressionValueUsed(node) || !inAsyncFunction(node)) {
+    return;
+  }
+
   const signature = checker.typeChecker.getResolvedSignature(node);
   if (signature === undefined) {
     return;
@@ -34,12 +40,7 @@ function checkCallExpression(checker: Checker, node: ts.CallExpression) {
     return;
   }
 
-  if (tsutils.isExpressionValueUsed(node)) {
-    return;
-  }
-
-  if (inAsyncFunction(node) &&
-      tsutils.isThenableType(checker.typeChecker, node)) {
+  if (tsutils.isThenableType(checker.typeChecker, node)) {
     checker.addFailureAtNode(node, FAILURE_STRING);
   }
 }