Skip to content

Fix: Lack of URL encoding processing #31 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 18, 2020
Merged

Fix: Lack of URL encoding processing #31 #39

merged 2 commits into from
Nov 18, 2020

Conversation

masataka
Copy link

@masataka masataka commented Nov 18, 2020

  • launch.json added to .gitignore to be able to attach my own projects for incremental debugging.
  • Fixed Lack of URL encoding processing #31, but only for public file paths.
    • added decodeURI().
    • moved the code block up to top of the serving order.
    • const lastModified = info.mtime?.toUTCString() ?? new Date().toUTCString()
    • Deno.lstat -> Deno.lstatSync, Deno.readFile -> Deno.readFileSync

@masataka masataka requested a review from ije as a code owner November 18, 2020 06:21
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks @masataka

@ije
Copy link
Member

ije commented Nov 18, 2020

hi @masataka, would you please check the pages/apis routes with spaces or no-ascii charsets? or i will do it later. thanks, great work!

@masataka
Copy link
Author

@ije OK! I will try.

@ije
Copy link
Member

ije commented Nov 18, 2020

@masataka cool, thanks!

@masataka
Copy link
Author

@ije page/ works as is, without modification. api/ doesn't work. Maybe dynamic import can't resolve some file path. From now on, I will read the source code of Page loading.

@masataka
Copy link
Author

@ije Modifying the API route is symptomatic.

@ije
Copy link
Member

ije commented Nov 18, 2020

@masataka thanks, i'm going to merge this.

@ije ije merged commit 88c8929 into alephjs:master Nov 18, 2020
@masataka masataka deleted the fix-#31 branch November 19, 2020 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of URL encoding processing
2 participants