Skip to content

fix for outputDir #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2021
Merged

fix for outputDir #263

merged 1 commit into from
Apr 11, 2021

Conversation

chibat
Copy link
Contributor

@chibat chibat commented Apr 11, 2021

The specified outputDir does not work partially.

$ deno install --unstable -A -f -n aleph https://deno.land/x/aleph/cli.ts
$ aleph --version
aleph.js 0.3.0-alpha.28
deno 1.8.3
v8 9.0.257.3
typescript 4.2.2
$ aleph init hello
$ cd hello

$ echo '
import type { Config } from "https://deno.land/x/[email protected]/types.ts"

export default (): Config => ({
  outputDir: "/docs"  
})
' > aleph.config.ts

$ aleph build
$ ls dist
_aleph  logo.svg
$ ls docs
404.html  _aleph  index.html

I expect the following:

$ ls dist
ls: cannot access 'dist': No such file or directory
$ ls docs
404.html  _aleph  index.html  logo.svg

I fixed it.
I would appreciate it if you could check it.

@chibat chibat requested a review from ije as a code owner April 11, 2021 09:41
Copy link
Member

@ije ije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks @chibat

@ije ije merged commit 0cc867e into alephjs:master Apr 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants