Deno 1.7.0 incompatibility

[FallingSnow]

$ aleph dev 
Check https://deno.land/x/aleph@v0.2.28/cli.ts
Check https://deno.land/x/aleph@v0.2.28/cli/dev.ts
error: Uncaught (in promise) NotSupportedError: Cannot set "location".
        throw new DOMException(`Cannot set "location".`, "NotSupportedError");
              ^
    at set (deno:op_crates/web/12_location.js:340:15)
    at Function.assign (<anonymous>)
    at Project._init (project.ts:600:16)
    at async project.ts:106:13
    at async start (server.ts:12:5)

$ deno --version
deno 1.7.0 (release, x86_64-unknown-linux-gnu)
v8 8.9.255.3
typescript 4.1.3

See denoland/deno#4981 (comment)

[FallingSnow]

See for more info.

aleph.js/project.ts

Line 620 in 0456c9d

location: {

[FallingSnow]

Possibly related changes to globalThis.location: https://deno.land/posts/v1.7#add-support-for-codeglobalthislocationcode-and-relative-fetch

[shadowtime2000]

We have to figure out some way for the SSR part to basically run with --location. This will need some more thought.

[FallingSnow]

Removing the following seems to be working for the time being.

aleph.js/project.ts

Lines 620 to 633 in 0456c9d

	location: {
	protocol: 'http:',
	host: 'localhost',
	hostname: 'localhost',
	port: '',
	href: 'https://localhost/',
	origin: 'https://localhost',
	pathname: '/',
	search: '',
	hash: '',
	reload() { },
	replace() { },
	toString() { return this.href },
	},

[shadowtime2000]

Yeah it prob should work, but I feel like we should look into changing how we do SSR right now. Currently we use a fork of Deno DOM, but as @ije said, we should try avoiding use of deno dom to polyfill everything.

[FallingSnow]

Okie.

I do feel if this doesn't break anything and does solve the issue, this or another fix should be added. Would be a bummer if someone came along with everything up to date and aleph fails.

[shadowtime2000]

I don't know for sure but I think the new compiler is changing the way we do SSR

[ije]

@FallingSnow you are right, i think we can use Object.defineProperty to hack deno's limit.

[ije]

ensure we can get a right location object in SSR, even i don't recommend to access it.

[shadowtime2000]

@FallingSnow you are right, i think we can use Object.defineProperty to hack deno's limit.

It doesn't seem like that is possible

[ije]

ok, i'm going to remove all the browser polyfill objects: 068062f