Skip to content

eslint-config-airbnb: allow eslint-plugin-react-hooks 2 #2083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

eslint-config-airbnb: allow eslint-plugin-react-hooks 2 #2083

wants to merge 1 commit into from

Conversation

christophehurpeau
Copy link
Contributor

@christophehurpeau christophehurpeau commented Aug 30, 2019 •
edited
Loading

This allows to install eslint-plugin-react-hooks 2 by adding it in peerDependencies

@ljharb
Copy link
Collaborator

ljharb commented Aug 30, 2019

What are the rule changes that warranted a v2?

ljharb
ljharb requested changes Aug 30, 2019
View reviewed changes
Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we allow both in peer deps, we have to allow both in dev deps, and test in both.

@ljharb ljharb mentioned this pull request Sep 2, 2019
Closed
@perrin4869 perrin4869 mentioned this pull request Sep 16, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophehurpeau @ljharb