Persistence of shares implemented(not yet a full version) #219
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agilelab-tmnd1991
requested changes
Feb 5, 2024
Comment on lines
+18
to
+24
| @Inject | ||
| ShareRepository shareRepository; | ||
|
|
||
| @Inject | ||
| public JdbcStorageManager(){ | ||
| this.shareRepository = new ShareRepository(); | ||
| } |
There was a problem hiding this comment.
Let's use constructor based injection, also have a look at:
https://agile-lab-dev.github.io/whitefox/docs/development_guidelines
Comment on lines
+34
to
+45
| List<Share> shares = shareRepository.listAll().stream() | ||
| .map(ShareMapper::shareDaoToShare) | ||
| .collect(Collectors.toList()); | ||
| var totalSize = shares.size(); | ||
| if (offset > totalSize) { | ||
| throw new InvalidPageTokenException( | ||
| String.format("Invalid Next Page Token: token %s is larger than totalSize", offset)); | ||
| } else { | ||
| return new ResultAndTotalSize<>( | ||
| shares.stream().skip(offset).limit(maxResultSize).collect(Collectors.toList()), | ||
| totalSize); | ||
| } |
There was a problem hiding this comment.
This eagerly fetches all shares, it might get very slow when a lot of shares are created.
Have a look at: https://quarkus.io/guides/hibernate-orm-panache#paging
| import java.util.Optional; | ||
| @Entity | ||
| @Table(name = "share") | ||
| public class ShareDao { |
There was a problem hiding this comment.
If you can/want you can use Lombok to auto-generate some boilerplate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just the wip for a general structure for jdbc persistence, if this is alright I'll model all the entities that are required for persistence then make a big PR