add an iceberg table loader #178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
January 22, 2024 14:37
added 2 commits
January 23, 2024 21:02
tmnd1991
reviewed
Jan 24, 2024
There was a problem hiding this comment.
I will need to double-check code organisation when I'm a bit less asleep, but content looks good, just some small quirks in error handling.
I might be too asleep but I can't find any test where we read an iceberg table using the delta-sharing connector (i.e. through Spark or testing the "query" endpoint).
We should add such test
server/core/src/main/java/io/whitefox/core/MetastoreProperties.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/aws/utils/StaticCredentialsProvider.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/AwsGlueConfigBuilder.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/AbstractSharedTable.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/IcebergCatalogHandler.java
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/IcebergCatalogHandler.java
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/IcebergCatalogHandler.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/IcebergSharedTable.java
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/IcebergTableLoader.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/IcebergTableLoader.java
Show resolved
Hide resolved
tmnd1991
reviewed
Jan 24, 2024
server/core/src/main/java/io/whitefox/core/services/AwsGlueConfigBuilder.java
Outdated
Show resolved
Hide resolved
server/core/src/main/java/io/whitefox/core/services/AbstractSharedTable.java
Outdated
Show resolved
Hide resolved
tmnd1991
reviewed
Jan 24, 2024
server/core/src/main/java/io/whitefox/core/services/IcebergTableLoader.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.