Skip to content

Fix compatibility with TypeScript projects #1627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 28, 2022
Merged

Fix compatibility with TypeScript projects #1627

merged 9 commits into from
Jul 28, 2022

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jul 27, 2022 •
edited
Loading

davidyuk added 5 commits July 27, 2022 14:00
@davidyuk
style: enable eslint for mjs files
b05da6c
@davidyuk
test: typescript node using ts-node
3d64c38
@davidyuk
refactor: convert to array to avoid inlining as strings to fix TS error
dc3ec32 
> Type '"ok" | "ct" | "ak" | "ch"' does not satisfy the constraint 'Encoding'
@davidyuk
fix(node): don't transform autorest properties
7982327 
This significantly improves error messages in some cases.
@davidyuk
fix(node): avoid ts-expect-error missed in generated d.ts file
60d9755 
>  TransformedNode defines instance member property 'sendOperationRequest', but extended class
'Node' defines it as instance member function.

fixes on consumer side
@codecov
Copy link

codecov bot commented Jul 27, 2022 •
edited
Loading

Codecov Report

Merging #1627 (ac90fc3) into develop (eb9021c) will increase coverage by 0.01%.
The diff coverage is 96.55%.

@@             Coverage Diff             @@
##           develop    #1627      +/-   ##
===========================================
+ Coverage    83.19%   83.21%   +0.01%     
===========================================
  Files           64       64              
  Lines         3071     3074       +3     
  Branches       548      549       +1     
===========================================
+ Hits          2555     2558       +3     
  Misses         303      303              
  Partials       213      213
Impacted Files Coverage Δ
src/Node.ts 95.45% <95.00%> (ø)
src/tx/builder/helpers.ts 91.80% <100.00%> (+0.42%) ⬆️
src/utils/crypto.ts 96.29% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb9021c...ac90fc3. Read the comment docs.

@davidyuk davidyuk mentioned this pull request Jul 27, 2022
Merged
@subhod-i
Copy link
Contributor

@davidyuk @marc0olo we need these changes with the next release for the hackathon boilerplates.

@subhod-i
Copy link
Contributor

subhod-i commented Jul 28, 2022 •
edited
Loading

@davidyuk can we add this to #1625

@davidyuk davidyuk merged commit e7327e9 into develop Jul 28, 2022
@davidyuk davidyuk deleted the feature/fixes branch July 28, 2022 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidyuk @subhod-i