Skip to content

Prevent publishing "NaN" literally #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Prevent publishing "NaN" literally #57

wants to merge 1 commit into from

Conversation

ndoo
Copy link

@ndoo ndoo commented Sep 25, 2016

  • Describe the scope of your change - Prevent publishing (return false) if passing a NaN float/double
  • Describe any known limitations with your change. - You won't be able to see literal NaNs from MQTT feeds (but you should be tracing math/logic issues through your code/prototype, not through MQTT feeds and dashboards)
  • Please run any tests or examples that can exercise your modified code. - WFM (compiles fine as a library to existing code)

@ndoo ndoo mentioned this pull request Sep 25, 2016
@ndoo
Copy link
Author

ndoo commented May 20, 2025

Ping, if there is no interest I shall close my PR.

@tyeth
Copy link
Contributor

tyeth commented May 20, 2025

Hey 👋 thank you so much for your contribution!
I believe there was a decision last year to send NaN when appropriate for some sensors in the Adafruit WipperSnapper project. While I agree with your statement/assumption about keeping logic in the code, it's not always possible or desirable.

This PR is unlikely to be merged any time soon, but maybe in the future.

@ndoo
Copy link
Author

ndoo commented May 20, 2025

Thanks, in that case I shall close the PR.

@ndoo ndoo closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants