AudioWorkletNodeOptions.outputChannelCount #1386
Conversation
| "AudioWorkletNodeOptions">numberOfOutputs</a> and | ||
| <a data-link-for= | ||
| "AudioWorkletNodeOptions">outputChannelCount</a>, various | ||
| channel configurations can be achieved. |
There was a problem hiding this comment.
Hmm. I actually prefer this way. I think a list is better than using <table> element. We only have 3 cases with a single description for each.
index.html
Outdated
| @@ -9267,7 +9327,8 @@ <h2 id="defining-a-valid-audioworkletprocessor"> | |||
| <code>Float32Array</code> of audio samples for the | |||
| <code>m</code>th channel of <code>n</code>th input. While the | |||
| number of inputs is fixed at the construction, the number of | |||
| channels can be changed dynamically. | |||
| channels can be changed dynamically based on | |||
| <a>computedNumberOfChannels</a> | |||
index.html
Outdated
| @@ -9267,7 +9327,8 @@ <h2 id="defining-a-valid-audioworkletprocessor"> | |||
| <code>Float32Array</code> of audio samples for the | |||
| <code>m</code>th channel of <code>n</code>th input. While the | |||
| number of inputs is fixed at the construction, the number of | |||
There was a problem hiding this comment.
Not part of the PR, but noticed that "is fixed at the construction" -> "is fixed at construction"
index.html
Outdated
| of channels can be changed dynamically. | ||
| for <code>m</code>th channel of <code>n</code>th output. The | ||
| number of channels in the output can be dynamically changed | ||
| only when the node has single output. |
There was a problem hiding this comment.
A link to the section describing this would be helpful.
index.html
Outdated
| </dt> | ||
| <dd> | ||
| This is used to configure the number of channels in each | ||
| output. <code>IndexSizeError</code> MUST be thrown if the |
There was a problem hiding this comment.
I think you still need to say a little bit more on what this means. Something like "outputChannelCount[n]" specifies the number of channels for output number n". Or something.
|
@joeberkovitz Could you take a look? |
|
@padenot Could you take a look? |
index.html
Outdated
| "AudioWorkletNodeOptions">numberOfOutputs</a>. A | ||
| <code>NotSupportedError</code> exception MUST be thrown if a | ||
| channel count is not in the valid range of <a data-link-for= | ||
| "AudioNode">channelCount</a>. |
There was a problem hiding this comment.
This seems confusing -- first of all, channelCount is not a range, it's a single number. Also, it's not clear if you mean the option dictionary value AudioNodeOptions.channelCount, or the read-only attribute AudioNode.channelCount (I'm guessing you mean the options value, but then you have to account for what happens if this was omitted, in which case there is no defined channel count for up/downmixing).
There was a problem hiding this comment.
What I meant was AudioNode.channelCount here. We have a defined range for that property and the same rules should be applied to each value in AudioWorkletNodeOptions.outputChannelCount array. I thought data-link-for was quite clear, but it's not visible in the actual page. So I edited the text to clarify what channelCount means here.
Also the behavior on unspecified (omitted) outputChannelCount is described in the following section.
index.html
Outdated
| "AudioWorkletNodeOptions">numberOfOutputs</a> = 0 | ||
| <ul> | ||
| <li> | ||
| <code>NotSupportedError</code> MUST be thrown. |
There was a problem hiding this comment.
must be thrown... by the constructor
Preview | Diff