Skip to content

[Linking] Remove 'Required' (0x3d) prefix from features section #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

aheejin
Copy link
Member

@aheejin aheejin commented Oct 25, 2024

This has not been emitted in LLVM since
llvm/llvm-project@3f34e1b.

Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's give some time to see if there are any objections.

Co-authored-by: Thomas Lively <[email protected]>
@aheejin
Copy link
Member Author

aheejin commented Nov 5, 2024

Given that this has not seen any objections, will merge this and other PRs in the tools.

@aheejin aheejin merged commit 9b5394d into WebAssembly:main Nov 5, 2024
@aheejin aheejin deleted the remove_required branch November 5, 2024 00:11
aheejin added a commit to llvm/llvm-project that referenced this pull request Nov 5, 2024
This has not been emitted since

3f34e1b.

The corresponding proposed tool-conventions change:
WebAssembly/tool-conventions#236
aheejin added a commit to emscripten-core/emscripten that referenced this pull request Nov 5, 2024
This has not been emitted in LLVM since

llvm/llvm-project@3f34e1b.

The corresponding proposed tool-conventions change:
WebAssembly/tool-conventions#236
aheejin added a commit to WebAssembly/binaryen that referenced this pull request Nov 5, 2024
This has not been emitted in LLVM since

llvm/llvm-project@3f34e1b.

The corresponding proposed tool-conventions change:
WebAssembly/tool-conventions#236
PhilippRados pushed a commit to PhilippRados/llvm-project that referenced this pull request Nov 6, 2024
This has not been emitted since

llvm@3f34e1b.

The corresponding proposed tool-conventions change:
WebAssembly/tool-conventions#236
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants