clarify setjmp/longjmp limitations when implemented using exceptions #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| opposite approach). (This can enable all of the defined behavior of | ||
| `setjmp`/`longjmp`, namely unwinding the stack, but does not allow | ||
| the undefined behavior case of jumping forward to a stack that | ||
| was already unwound.) |
There was a problem hiding this comment.
I'd drop the extra parens.
Maybe discuss coroutines? That's usually what sjlj UB is used for.
|
Perhaps worth pointing out that explicit coroutine support is being considered separately (so that it's not so bad that longjmp can't jump forward). |
|
Done. |
|
Thanks! |
lukewagner
added a commit
that referenced
this pull request
Apr 30, 2015
clarify setjmp/longjmp limitations when implemented using exceptions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sunfishcode - this is what I was suggesting in that comment, to clarify about setjmp/longjmp. I also changed it to
mayas you suggested. Up to you though, if you don't think the clarification is worth it, just close this.