Skip to content

Slightly improve new table C APIs #3604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 26, 2021
Merged

Slightly improve new table C APIs #3604

merged 1 commit into from
Feb 26, 2021

Conversation

dcodeIO
Copy link
Contributor

@dcodeIO dcodeIO commented Feb 24, 2021

Uses BinaryenIndex instead of int to mirror parameter types in table construction, and adds setters for name, initial and max. Plus descriptions and tests.

@dcodeIO dcodeIO mentioned this pull request Feb 24, 2021
Merged
1 task
@dcodeIO dcodeIO changed the title Slightly improve multi table C APIs Slightly improve new table C APIs Feb 24, 2021
@martianboy
Copy link
Contributor

Thanks for this. I'm still working to implement the tables part of reference types proposal, so more changes to the C APIs will be coming.

tlively
tlively approved these changes Feb 26, 2021
View reviewed changes
Copy link
Member

@tlively tlively left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix ups :)

@dcodeIO dcodeIO merged commit b3f6791 into WebAssembly:main Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tlively tlively tlively approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dcodeIO @martianboy @tlively