Supporting hyphens on endpoints #257
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According with https://developer.wordpress.org/reference/functions/register_post_type/#parameters custom post types can have both underscore and hyphens, resulting in endpoints like
my_content
ormy-content
. Current API supports only underscore.I'm not a WP or a Node developer, but I think this should be either addressed or at least documented.
A temporary workaround is to call the endpoint with
site['my-content'].get()
.This patch add hyphens supports on routes names replacing.
Ideally the exact regexp should be
[^a-z]+
, in order to cover any future changes and plugins creating weird endpoints.