Gracefully handle GitHub plugin git exec failures #545
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If shelljs exec of git fails at the exec level, return null to add to ignore list and continue.
aciccarello
approved these changes
Jun 30, 2017
|
@aciccarello Raises a different question I suppose - is there a way to run with all default plugins but that one? The specific situation here is an extremely non-standard node location on a unc path which causes problems for shelljs.exec. It's easier to handle the error and continue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If shelljs exec of git rev-parse fails at the exec level, return null to add to ignored paths and continue.