-
-
Notifications
You must be signed in to change notification settings - Fork 735
support export-declaration #1079
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@shrinktofit Can you add tests to ensure we don't regress on this? |
We should evaluate this next to #801, which makes a lot more changes and may be a more complete implementation. (In particular, the changes it makes for handling renames appear to be rather important) It might be best to merge this until we have the time to get to 801. |
Firstly: I published this and #1096 as NPM Secondly... I noticed a problem; not sure if it's with this PR, but it seems related... the problem appears when I use this syntax along with the import * as Utils from "./utils";
export { Utils }; Doing this, I would expect Here, some screenshots to show the difference: I threw up a demo repo here for anyone that's looking to reproduce: https://github.com/gnidan-finds-bugs/typedoc-pull-1079 Hope this is useful information. Let me know if there's anything I can do to help! |
Can this get scheduled for 0.16 as well? Not sure what the status is in relation to #801 |
This should be superceded by #801 |
Adding this to the 0.16 as at least one of this & #801 needs to be merged, and after spending a few hours understanding how 801 works yesterday, I want to go over this PR more carefully, I think the method used to convert modules here might be better. |
hey @gnidan any chance to publish updated gnd/typedoc? :) |
#1157 has been merged, which includes support for export declarations :) Thank you for the PR, it proved quite useful in determining how best to handle export declarations. |
#639