Skip to content

Implement hyperclick package #448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
park9140 opened this issue Jul 9, 2015 · 13 comments · Fixed by #1265
Closed

Implement hyperclick package #448

park9140 opened this issue Jul 9, 2015 · 13 comments · Fixed by #1265

Comments

@park9140
Copy link
Contributor

park9140 commented Jul 9, 2015

Part of Nuclide is the hyperclick package, https://atom.io/packages/hyperclick, it allows for interacting with text in the editor while holding the alt key, via a service.

Some thoughts of things we could implement with this.

  • Jump to definition.
  • allow quick fixes to define syntax errors they are associated with
    • for example quick fix to implement an interface could be attached to the, the syntax error for a interface not being implemented.
@adidahiya
Copy link

+1 this would be awesome!

@littleStudent
Copy link

Is anyone working on this? would love to see this feature added to atom-typescript.
Never did atom package development, would be lots of work for me to get into this stuff.

@basarat
Copy link
Member

basarat commented Jan 2, 2016

Is anyone working on this?

Nope 🌹

@cevek
Copy link

cevek commented Apr 26, 2016

+1

1 similar comment
@marcoskichel
Copy link

+1

wingyplus added a commit to wingyplus/atom-typescript that referenced this issue Jul 6, 2016
wingyplus added a commit to wingyplus/atom-typescript that referenced this issue Jul 6, 2016
basarat pushed a commit that referenced this issue Jul 11, 2016
* Implement go to declaration with hyperclick provider

Ref #448

* Custom word matching to match token and string

Ref #448
@markvandenbrink
Copy link

This is very nice, but there is a problem using the ctrl-key, since this key is used to make multiple selections/use multiple text cursors in Atom (which is very useful). Maybe it is better to use the alt-key as described in the readme of hyperclick:

  • <alt> or <alt-mousemove> underlines clickable text under the mouse.
  • <alt-mousedown> performs the action associated with the clickable text.
  • <cmd-alt-enter> performs the action on the text under the cursor.

@wingyplus
Copy link
Contributor

@markogresak Atom Typescript implement hyperclick provider for jump to declaration since version 10.0.1 . You can use alt key that hyperclick mapped.

@markvandenbrink
Copy link

It seems the ctrl-key is mapped on Windows instead of the alt-key. Submitted a PR to change this behavior: facebookarchive/nuclide#612

@tlaverdure
Copy link

I agree with @markvandenbrink about the keymap issue. I'm used to using cmd + click to make multiple selections.

Is this also only supposed to work with typescript files? Seem to see the white hyperclick underline in every file type I'm in when holding down cmd which makes this feature buggy.

@robofish
Copy link

If i'm not mistaken, the integration is gone again with atom typescript v11? 😅

@guncha
Copy link
Contributor

guncha commented Mar 28, 2017

@robofish, it sure is. Command+click is also used to place multiple cursors and if hyperclick is only used for jumping to the definition, I didn't see the point in keeping it since clicking on the symbol and pressing F12 is very close, though I agree that switching from the mouse to the keyboard is not perfect. I might be convinced that it make sense to use with quickfixes though.

@andrewstart
Copy link

Hyperclick added an option to change which modifier(s) is used, so that it doesn't have to interfere with multiple cursors. I'd also ask that the integration be added back.

@sverrejoh
Copy link
Contributor

I implemented this and made a pull request, which you can test if you want: #1265

@TypeStrong TypeStrong locked and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.