-
Notifications
You must be signed in to change notification settings - Fork 203
Implement hyperclick package #448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
+1 this would be awesome! |
Is anyone working on this? would love to see this feature added to atom-typescript. |
Nope 🌹 |
+1 |
1 similar comment
+1 |
This is very nice, but there is a problem using the
|
@markogresak Atom Typescript implement hyperclick provider for jump to declaration since version 10.0.1 . You can use |
It seems the ctrl-key is mapped on Windows instead of the alt-key. Submitted a PR to change this behavior: facebookarchive/nuclide#612 |
I agree with @markvandenbrink about the keymap issue. I'm used to using cmd + click to make multiple selections. Is this also only supposed to work with typescript files? Seem to see the white hyperclick underline in every file type I'm in when holding down cmd which makes this feature buggy. |
If i'm not mistaken, the integration is gone again with atom typescript v11? 😅 |
@robofish, it sure is. Command+click is also used to place multiple cursors and if hyperclick is only used for jumping to the definition, I didn't see the point in keeping it since clicking on the symbol and pressing F12 is very close, though I agree that switching from the mouse to the keyboard is not perfect. I might be convinced that it make sense to use with quickfixes though. |
Hyperclick added an option to change which modifier(s) is used, so that it doesn't have to interfere with multiple cursors. I'd also ask that the integration be added back. |
I implemented this and made a pull request, which you can test if you want: #1265 |
Part of Nuclide is the hyperclick package, https://atom.io/packages/hyperclick, it allows for interacting with text in the editor while holding the alt key, via a service.
Some thoughts of things we could implement with this.
The text was updated successfully, but these errors were encountered: