Make the ending comma/curlybrace after templateUrl optional. #67
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 96.42% 96.42%
=======================================
Files 1 1
Lines 28 28
Branches 5 5
=======================================
Hits 27 27
Misses 1 1
Continue to review full report at Codecov.
|
|
Second commit changes the pull request to essentially switch the "match until you find a quote, double quote, or backtick" to "match until you find a quote, double quote, or backtick that doesn't follow a backslash". This works for all the test cases and for my personal app. Any other suggestions would be very welcome. |
added 4 commits
April 26, 2017 19:34
This was referenced Apr 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this is foolproof for all use cases this loaders is being used in. I've only tested it against my own app and saw it working. It simply makes the comma at the end of the line optional.
This will be a WIP until I get the tests passing.
If there are no downsides to this, then it should fix #50 and #58.