fix(react-router): fix custom link type ref inference #4121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom links created by
createLink
would incorrectly inferref
values for non-intrinsic components (such as those with their ownref
prop like the documented example), which would result in the ref being "double-wrapped". That is:Before:
After fix:
This patch, the equivilant applied directly to
link.d.ts
viayarn patch
, has been our workaround and it appears to work well:@tanstack-react-router-npm-1.120.3-f6c72d7c75.patch